[PR #5914/5fab03a5 backport][3.8] Further optimize the logo/icon #6059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Further optimized, now using viewbox of 0 0 24 24 It's not exactly required, but projects such as simple-icons use a 24 24 viewbox, and dont move the viewbox into the middle for no reason (instead starting at 0 0) * Added color to the icon * Update aiohttp-plain.svg * Added same height width as original * Update aiohttp-plain.svg * Create 5914.misc * Make the change note clearer Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua> (cherry picked from commit 5fab03a)
psf-chronographer
bot
added
the
bot:chronographer:provided
webknjaz
deleted the
patchback/backports/3.8/5fab03a523010c0fb531c064f300e6cfe0d5b67b/pr-5914
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #5914 as merged into master (5fab03a).
What do these changes do?
The only thing this does is make further optimizations to the svg of the icon. It also changes the viewbox from 76 to 24, so that it can be used easier for projects that use tools like simple-icons
Are there changes in behavior for the user?
Not really, unless the extract the raw path data. It still has the same height & width, so should not affect users.
Related issue number
None
Checklist
Irrelevant:
CONTRIBUTORS.txtRelevant:
CHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.