Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI for 3.8 #5505

Closed
wants to merge 5 commits into from
Closed

Fix CI for 3.8 #5505

wants to merge 5 commits into from

Conversation

derlih
Copy link
Contributor

@derlih derlih commented Feb 28, 2021

What do these changes do?

Fixes CI for 3.8 branch

Are there changes in behavior for the user?

No

Related issue number

No

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Feb 28, 2021
@derlih derlih changed the title [WIP] Fix CI for 3.8 Fix CI for 3.8 Feb 28, 2021
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this will work long-term. I think the legacy resolver is to be removed soon.

@derlih
Copy link
Contributor Author

derlih commented Mar 1, 2021

I think then this issue jazzband/pip-tools#1190 will be implemented.
Also I think we should fix the CI ASAP. Doesn't matter how.

@webknjaz
Copy link
Member

webknjaz commented Mar 1, 2021

@derlih it was agreed to use just -r in #5486.

@webknjaz
Copy link
Member

Superseded by #5486.

@webknjaz webknjaz closed this Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants