Ensure zero byte files can be sent #5125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psf-chronographer
bot
added
the
bot:chronographer:provided
bdraco
force-pushed
the
handle_zero_byte_files
branch
from
67ab952
to
8843964
Compare
Codecov Report
@@ Coverage Diff @@
## master #5125 +/- ##
==========================================
+ Coverage 97.50% 97.54% +0.03%
==========================================
Files 43 43
Lines 8824 8825 +1
Branches 1415 1416 +1
==========================================
+ Hits 8604 8608 +4
+ Misses 103 102 -1
+ Partials 117 115 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
💚 Backport successfulThe PR was backported to the following branches:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Restores previous behavior of not throwing an exception when sending a zero byte file.
Are there changes in behavior for the user?
Regression fix
Related issue number
Fixes #5124
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.