Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.6] Don't cancel web handler on disconnection (#4080) #4772

Closed
wants to merge 3 commits into from
Closed

[3.6] Don't cancel web handler on disconnection (#4080) #4772

wants to merge 3 commits into from

Conversation

Jackenmen
Copy link
Contributor

@Jackenmen Jackenmen commented May 24, 2020

What do these changes do?

Backport #4080 to aiohttp 3.6. I'm not sure whether there's gonna be another 3.6 release or if 3.7 is still planned but this allows to handle connections issues properly so would be good to have.

#3804 wasn't backported to 3.6 so I had to put the try-finally block in the start() as _handle_request method doesn't exist here, I'm not entirely sure if I've done it properly. I could alternatively also backport #3804, either in this or seperate PR that this would depend on.

Are there changes in behavior for the user?

ConnectionResetError is raised on writing to closing transport instead of a warning.

Related issue number

#4080

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label May 24, 2020
@asvetlov
Copy link
Member

The time window for aiohttp 3.6 is closed. Let's see what can we do for 3.7

@asvetlov asvetlov closed this Oct 16, 2020
@Jackenmen Jackenmen deleted the backport-4080-3.6 branch October 17, 2020 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants