Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests in master #4530

Merged
merged 1 commit into from
Jan 26, 2020
Merged

Fix tests in master #4530

merged 1 commit into from
Jan 26, 2020

Conversation

hh-h
Copy link
Contributor

@hh-h hh-h commented Jan 25, 2020

What do these changes do?

It fixes test in master after 4d03dbb

Are there changes in behavior for the user?

No

Related issue number

No

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@hh-h hh-h requested a review from asvetlov as a code owner January 25, 2020 13:55
@codecov-io
Copy link

codecov-io commented Jan 25, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@4d03dbb). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4530   +/-   ##
=========================================
  Coverage          ?   97.59%           
=========================================
  Files             ?       43           
  Lines             ?     8907           
  Branches          ?     1403           
=========================================
  Hits              ?     8693           
  Misses            ?       95           
  Partials          ?      119

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d03dbb...b0eefb7. Read the comment docs.

@asvetlov asvetlov merged commit 41e1450 into aio-libs:master Jan 26, 2020
@asvetlov
Copy link
Member

Thanks!

@hh-h hh-h deleted the fix-tests branch January 27, 2020 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants