Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

body_exists for requests without body should be False #4529

Merged
merged 1 commit into from
Jan 26, 2020
Merged

body_exists for requests without body should be False #4529

merged 1 commit into from
Jan 26, 2020

Conversation

hh-h
Copy link
Contributor

@hh-h hh-h commented Jan 25, 2020 •
edited
Loading

What do these changes do?

This PR tries to implement this logic for _http_parser

Are there changes in behavior for the user?

No

Related issue number

#4528

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@hh-h hh-h requested a review from asvetlov as a code owner January 25, 2020 13:38
asvetlov
asvetlov approved these changes Jan 26, 2020
View reviewed changes
Copy link
Member

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jan 26, 2020
@hh-h
Copy link
Contributor Author

hh-h commented Jan 26, 2020

Added CHANGES file

@asvetlov
Copy link
Member

Please sync with the lastest master to get rid of unittest error

@codecov-io
Copy link

codecov-io commented Jan 26, 2020 •
edited
Loading

Codecov Report

Merging #4529 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4529   +/-   ##
=======================================
  Coverage   97.59%   97.59%           
=======================================
  Files          43       43           
  Lines        8907     8907           
  Branches     1403     1403           
=======================================
  Hits         8693     8693           
  Misses         95       95           
  Partials      119      119

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41e1450...495bebb. Read the comment docs.

@hh-h
Copy link
Contributor Author

hh-h commented Jan 26, 2020

Done, green 💚

@asvetlov asvetlov merged commit 72176b2 into aio-libs:master Jan 26, 2020
@asvetlov
Copy link
Member

Thanks!

asvetlov pushed a commit that referenced this pull request Jan 26, 2020
@hh-h @asvetlov
[3.7] body_exists for requests without body should be False (#4529)
504e649 
(cherry picked from commit 72176b2)

Co-authored-by: hh-h <hh-h@users.noreply.github.com>
asvetlov added a commit that referenced this pull request Jan 27, 2020
@asvetlov @hh-h
[3.7] body_exists for requests without body should be False (#4529) (#…
be4056d 
…4533)

(cherry picked from commit 72176b2)

Co-authored-by: hh-h <hh-h@users.noreply.github.com>

Co-authored-by: hh-h <hh-h@users.noreply.github.com>
@hh-h hh-h deleted the fix-get-body branch January 27, 2020 12:36
asvetlov pushed a commit that referenced this pull request Oct 16, 2020
@hh-h @asvetlov
body_exists for requests without body should be False (#4529)
bb054f5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov asvetlov approved these changes

Assignees
No one assigned
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hh-h @asvetlov @codecov-io