-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UrlDispatcher - add_routes returns a list of AbstractRoutes #4141
Merged
Merged
Changes from 5 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
4cf126d
UrlDispatcher - add_routes returns a list of AbstractRoutes
1920bd6
add myself to the contributors
3d1d6b2
AbstractRouteDef.register returns a list of registered AbstractRoutes
a0694c3
test_urldispatch - update get_info test according to new changes
ecb1248
web_routedef: cov fix
f046d42
docs: update add_routes and registers so they use proper markdown
1deafb3
Merge branch 'master' of github.com:aio-libs/aiohttp into urldispatcher
1fdb169
Update docs/web_reference.rst
zlatsic 43fe35d
Update docs/web_reference.rst
zlatsic 2846b45
Update docs/web_reference.rst
zlatsic bfa97ee
Update docs/web_reference.rst
zlatsic 16ead65
Update docs/web_reference.rst
zlatsic dcc9b80
Update docs/web_reference.rst
zlatsic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
`web.UrlDispatcher.add_routes` and `web.Application.add_routes` return a list | ||
of registered `AbstractRoute` instances. `AbstractRouteDef.register` (and all | ||
subclasses) return a list of registered resources registered resource. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -274,5 +274,6 @@ Young-Ho Cha | |
Yuriy Shatrov | ||
Yury Selivanov | ||
Yusuke Tsutsumi | ||
Zlatan Sičanica | ||
Марк Коренберг | ||
Семён Марьясин |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1413,6 +1413,8 @@ duplicated like one using :meth:`Application.copy`. | |
The table is a :class:`list` of :class:`RouteDef` items or | ||
:class:`RouteTableDef`. | ||
|
||
Returns a :class:`list` of registered :class:`AbstractRoute` instances. | ||
|
||
The method is a shortcut for | ||
``app.router.add_routes(routes_table)``, see also | ||
:meth:`UrlDispatcher.add_routes`. | ||
|
@@ -1569,6 +1571,8 @@ Router is any object that implements :class:`AbstractRouter` interface. | |
The table is a :class:`list` of :class:`RouteDef` items or | ||
:class:`RouteTableDef`. | ||
|
||
Returns a :class:`list` of registered :class:`AbstractRoute` instances. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The same |
||
|
||
.. versionadded:: 2.3 | ||
|
||
.. method:: add_get(path, handler, *, name=None, allow_head=True, **kwargs) | ||
|
@@ -2080,6 +2084,8 @@ The definition is created by functions like :func:`get` or | |
|
||
Abstract method, should be overridden by subclasses. | ||
|
||
Returns a list of registered `AbstractRoute` objects. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. And the same |
||
|
||
|
||
.. class:: RouteDef | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:returns:
markup as in the method above... versionchanged:: 3.7
markup, search in docs for the directive usage. The master is not ready for 4.0 release yet, I think we can publish 3.7 earlier.