Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Iterable hint instead of Sequence #4125

Merged
merged 2 commits into from
Oct 2, 2019
Merged

Use Iterable hint instead of Sequence #4125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4120bfc
Use Iterable hint instead of Sequence
stj Oct 1, 2019
cd50afa
Add changelog
stj Oct 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES/4125.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Use `Iterable` hint instead of `Sequence` for `Application` `middleware` parameter.
1 change: 1 addition & 0 deletions CONTRIBUTORS.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,7 @@ Simon Kennedy
Sin-Woo Bang
Stanislas Plum
Stanislav Prokop
Stefan Tjarks
Stepan Pletnev
Stephen Granade
Steven Seguin
Expand Down
2 changes: 1 addition & 1 deletion aiohttp/web_app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ class Application(MutableMapping[str, Any]):

def __init__(self, *,
logger: logging.Logger=web_logger,
middlewares: Sequence[_Middleware]=(),
middlewares: Iterable[_Middleware]=(),
handler_args: Mapping[str, Any]=None,
client_max_size: int=1024**2,
debug: Any=... # mypy doesn't support ellipsis
Expand Down