Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.5] fixed type annotation in method add_view in UrlDispatcher (#3880) #3887

Merged
merged 1 commit into from
Jul 5, 2019

Conversation

asvetlov
Copy link
Member

@asvetlov asvetlov commented Jul 5, 2019

(cherry picked from commit 049101b)

Co-authored-by: Ilya Chichak ilyachch@gmail.com

(cherry picked from commit 049101b)

Co-authored-by: Ilya Chichak <ilyachch@gmail.com>
@asvetlov asvetlov requested a review from webknjaz as a code owner July 5, 2019 08:50
@codecov-io
Copy link

codecov-io commented Jul 5, 2019

Codecov Report

Merging #3887 into 3.5 will increase coverage by 0.25%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              3.5    #3887      +/-   ##
==========================================
+ Coverage   97.86%   98.12%   +0.25%     
==========================================
  Files          44       44              
  Lines        8579     9043     +464     
  Branches     1380     1538     +158     
==========================================
+ Hits         8396     8873     +477     
+ Misses         78       69       -9     
+ Partials      105      101       -4
Impacted Files Coverage Δ
aiohttp/__init__.py 100% <0%> (ø) ⬆️
aiohttp/streams.py 98.2% <0%> (+0.26%) ⬆️
aiohttp/web.py 99.39% <0%> (+0.29%) ⬆️
aiohttp/helpers.py 96.74% <0%> (+0.5%) ⬆️
aiohttp/pytest_plugin.py 98% <0%> (+0.73%) ⬆️
aiohttp/web_runner.py 98.87% <0%> (+0.94%) ⬆️
aiohttp/connector.py 99.08% <0%> (+1.41%) ⬆️
aiohttp/tcp_helpers.py 93.33% <0%> (+3.33%) ⬆️
aiohttp/locks.py 100% <0%> (+7.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3fe4ec...3f72d27. Read the comment docs.

@asvetlov asvetlov merged commit f6a790d into 3.5 Jul 5, 2019
@asvetlov asvetlov deleted the backport-049101b-3.5 branch July 5, 2019 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants