Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct style for re-exported imports (for 3.5 branch) #3873

Merged
merged 3 commits into from
Jul 19, 2019

Conversation

AMDmi3
Copy link
Contributor

@AMDmi3 AMDmi3 commented Jun 26, 2019

What do these changes do?

Use correct style for re-exported imports, makes mypy --strict happy.

Are there changes in behavior for the user?

No

Related issue number

#3868

Checklist

  • I think the code is well written
  • Unit tests for the changes exist (no new code and functional changes though, so should be covered by existing tests)
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
  • Add a new news fragment into the CHANGES folder

@AMDmi3
Copy link
Contributor Author

AMDmi3 commented Jun 26, 2019

Please give me some more time, I was not aware from foo import (bar as baz) syntax is possible. Will redo the patches that way, that will also fix flake8.

aiohttp/web_ws.py Outdated Show resolved Hide resolved
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Jun 26, 2019

This pull request introduces 3 alerts and fixes 3 when merging 02c65fe into a3fe4ec - view on LGTM.com

new alerts:

  • 3 for Module-level cyclic import

fixed alerts:

  • 3 for Module-level cyclic import

@AMDmi3 AMDmi3 force-pushed the 3.5-fix-reexports branch 3 times, most recently from a5050a2 to 879a5d4 Compare June 26, 2019 16:47
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Jun 26, 2019

This pull request introduces 22 alerts and fixes 22 when merging 879a5d4 into a3fe4ec - view on LGTM.com

new alerts:

  • 22 for Module-level cyclic import

fixed alerts:

  • 22 for Module-level cyclic import

@codecov-io
Copy link

codecov-io commented Jun 26, 2019

Codecov Report

Merging #3873 into 3.5 will increase coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##              3.5    #3873     +/-   ##
=========================================
+ Coverage   97.86%   97.97%   +0.1%     
=========================================
  Files          44       44             
  Lines        8579     8770    +191     
  Branches     1380     1381      +1     
=========================================
+ Hits         8396     8592    +196     
+ Misses         78       72      -6     
- Partials      105      106      +1
Impacted Files Coverage Δ
aiohttp/__init__.py 100% <100%> (ø) ⬆️
aiohttp/web.py 99.51% <100%> (+0.41%) ⬆️
aiohttp/http.py 100% <100%> (ø) ⬆️
aiohttp/streams.py 98.2% <0%> (+0.26%) ⬆️
aiohttp/helpers.py 96.74% <0%> (+0.5%) ⬆️
aiohttp/locks.py 100% <0%> (+7.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3fe4ec...879a5d4. Read the comment docs.

@asvetlov
Copy link
Member

asvetlov commented Jul 5, 2019

Please fix merge conflicts

@AMDmi3
Copy link
Contributor Author

AMDmi3 commented Jul 15, 2019

Updated

@asvetlov asvetlov merged commit 185eca1 into aio-libs:3.5 Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants