Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop setup.py test support #3752

Merged
merged 1 commit into from
May 11, 2019
Merged

Drop setup.py test support #3752

merged 1 commit into from
May 11, 2019

Conversation

asvetlov
Copy link
Member

Closes #3518

We decided to not support setup.py test facility anymore.
Use make test now.
@webknjaz has a plan to add tox configuration -- it would be a nice addition.
tox can be used by CI and users who comfortable with this workflow.
For now on my daily aiohttp hacking I personally prefer old good makefiles

@asvetlov asvetlov requested a review from webknjaz as a code owner May 10, 2019 17:30
@cla-bot

This comment has been minimized.

@asvetlov asvetlov mentioned this pull request May 10, 2019
5 tasks
@codecov-io
Copy link

codecov-io commented May 10, 2019

Codecov Report

Merging #3752 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3752   +/-   ##
=======================================
  Coverage   97.87%   97.87%           
=======================================
  Files          43       43           
  Lines        8561     8561           
  Branches     1374     1374           
=======================================
  Hits         8379     8379           
  Misses         77       77           
  Partials      105      105

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8cbbcc...eef139c. Read the comment docs.

@asvetlov asvetlov merged commit 12b8e8c into master May 11, 2019
@asvetlov asvetlov deleted the drop-tests-require branch May 11, 2019 04:21
@webknjaz
Copy link
Member

I'd also add that setup.py test is officially discouraged during the last several years anyway.

@lock lock bot added the outdated label May 20, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
@aio-libs aio-libs unlocked this conversation Oct 28, 2021
@patchback
Copy link
Contributor

patchback bot commented Oct 28, 2021

Backport to 3.8: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 12b8e8c on top of patchback/backports/3.8/12b8e8c036df3b7e5ae2b7cff91f20b7c760ee62/pr-3752

Backporting merged PR #3752 into master

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/aio-libs/aiohttp.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/3.8/12b8e8c036df3b7e5ae2b7cff91f20b7c760ee62/pr-3752 upstream/3.8
  4. Now, cherry-pick PR Drop setup.py test support #3752 contents into that branch:
    $ git cherry-pick -x 12b8e8c036df3b7e5ae2b7cff91f20b7c760ee62
    If it'll yell at you with something like fatal: Commit 12b8e8c036df3b7e5ae2b7cff91f20b7c760ee62 is a merge but no -m option was given., add -m 1 as follows intead:
    $ git cherry-pick -m1 -x 12b8e8c036df3b7e5ae2b7cff91f20b7c760ee62
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Drop setup.py test support #3752 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/3.8/12b8e8c036df3b7e5ae2b7cff91f20b7c760ee62/pr-3752
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@aio-libs aio-libs locked as resolved and limited conversation to collaborators Oct 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants