-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop setup.py test support #3752
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## master #3752 +/- ##
=======================================
Coverage 97.87% 97.87%
=======================================
Files 43 43
Lines 8561 8561
Branches 1374 1374
=======================================
Hits 8379 8379
Misses 77 77
Partials 105 105 Continue to review full report at Codecov.
|
I'd also add that |
Backport to 3.8: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 12b8e8c on top of patchback/backports/3.8/12b8e8c036df3b7e5ae2b7cff91f20b7c760ee62/pr-3752 Backporting merged PR #3752 into master
🤖 @patchback |
Closes #3518
We decided to not support
setup.py test
facility anymore.Use
make test
now.@webknjaz has a plan to add
tox
configuration -- it would be a nice addition.tox
can be used by CI and users who comfortable with this workflow.For now on my daily aiohttp hacking I personally prefer old good makefiles