Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix local_addr annotation in TCPConnector.__init__ #3657

Closed

Conversation

Hanaasagi
Copy link
Member

@Hanaasagi Hanaasagi commented Mar 19, 2019

From the doc

  • local_addr (tuple) – tuple of (local_host, local_port) used to bind socket locally if specified.

resolve #3639

@codecov-io
Copy link

codecov-io commented Mar 19, 2019

Codecov Report

Merging #3657 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3657   +/-   ##
=======================================
  Coverage   94.83%   94.83%           
=======================================
  Files          43       43           
  Lines        8555     8555           
  Branches     1375     1375           
=======================================
  Hits         8113     8113           
  Misses        337      337           
  Partials      105      105
Impacted Files Coverage Δ
aiohttp/connector.py 96.18% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7345ffb...9e8ccf2. Read the comment docs.

@asvetlov
Copy link
Member

asvetlov commented May 7, 2019

Resolved by #3732

@Hanaasagi thank for the PR.
Sorry, I've merged the very similar code just before looking on your implementation

@asvetlov asvetlov closed this May 7, 2019
@lock lock bot added the outdated label May 20, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong type annotation for local_addr in TCPConnector.__init__
3 participants