Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract AccessLog into a separate module #3336

Merged
merged 1 commit into from
Oct 9, 2018
Merged

Conversation

asvetlov
Copy link
Member

@asvetlov asvetlov commented Oct 9, 2018

To avoid circular refs

@codecov-io
Copy link

codecov-io commented Oct 9, 2018

Codecov Report

Merging #3336 into master will decrease coverage by 0.02%.
The diff coverage is 95.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3336      +/-   ##
==========================================
- Coverage   98.01%   97.99%   -0.03%     
==========================================
  Files          43       44       +1     
  Lines        8025     8039      +14     
  Branches     1356     1357       +1     
==========================================
+ Hits         7866     7878      +12     
- Misses         66       67       +1     
- Partials       93       94       +1
Impacted Files Coverage Δ
aiohttp/web.py 98.85% <100%> (+0.01%) ⬆️
aiohttp/base_protocol.py 97.1% <100%> (ø) ⬆️
aiohttp/web_app.py 95.8% <100%> (+0.01%) ⬆️
aiohttp/web_protocol.py 92.52% <100%> (ø) ⬆️
aiohttp/helpers.py 97.64% <100%> (+0.18%) ⬆️
aiohttp/web_request.py 98.15% <100%> (ø) ⬆️
aiohttp/worker.py 99.07% <100%> (ø) ⬆️
aiohttp/client_proto.py 95.13% <60%> (-1.29%) ⬇️
aiohttp/web_log.py 96.93% <96.93%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd224f8...001a2cf. Read the comment docs.

@asvetlov asvetlov merged commit 9483209 into master Oct 9, 2018
@asvetlov asvetlov deleted the extract-access-log branch October 9, 2018 20:56
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants