Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bracket IPv6 addresses in the HOST header (#3304) #3305

Merged
merged 2 commits into from
Oct 4, 2018

Conversation

pollydrag
Copy link
Contributor

@pollydrag pollydrag commented Sep 30, 2018

What do these changes do?

Bracket IPv6 addresses in the HOST header

Are there changes in behavior for the user?

No changes

Related issue number

#3304

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@codecov-io
Copy link

codecov-io commented Sep 30, 2018

Codecov Report

Merging #3305 into master will decrease coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3305      +/-   ##
=========================================
- Coverage   98.07%     98%   -0.08%     
=========================================
  Files          43      43              
  Lines        8001    8020      +19     
  Branches     1354    1354              
=========================================
+ Hits         7847    7860      +13     
- Misses         63      66       +3     
- Partials       91      94       +3
Impacted Files Coverage Δ
aiohttp/client_reqrep.py 97.49% <100%> (-0.16%) ⬇️
aiohttp/helpers.py 97.46% <100%> (ø) ⬆️
aiohttp/tcp_helpers.py 90% <0%> (-6.67%) ⬇️
aiohttp/web_app.py 95.78% <0%> (-0.77%) ⬇️
aiohttp/payload.py 98.59% <0%> (-0.39%) ⬇️
aiohttp/typedefs.py 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 508adbb...690768c. Read the comment docs.

Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a news fragment as stated in the checklist

Copy link
Member

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pollydrag your PR is perfect but please add a change-note

@webknjaz
Copy link
Member

webknjaz commented Oct 2, 2018

(@pollydrag this means that you need to add a file to CHANGES/ folder)

@webknjaz
Copy link
Member

webknjaz commented Oct 2, 2018

And feel free to add yourself to the contributors list!

@asvetlov
Copy link
Member

asvetlov commented Oct 2, 2018

@pollydrag
Copy link
Contributor Author

@webknjaz @asvetlov Change-note done. Sorry for delay

@asvetlov
Copy link
Member

asvetlov commented Oct 4, 2018

thanks!

@asvetlov asvetlov merged commit 0875f7a into aio-libs:master Oct 4, 2018
@@ -162,6 +162,7 @@ Paulius Šileikis
Paulus Schoutsen
Pavel Kamaev
Pawel Miech
Pavel Polyakov
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is out of order. T U V W X Y Z

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!
Fixed by f6b81b3

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, sorry

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably need to lint that :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think linux sort can be used for this.
For example, the check might look like LC_ALL=C sort -c CONTRIBUTORS.txt
But first you need to make it sorted: LC_ALL=C sort -o CONTRIBUTORS.txt CONTRIBUTORS.txt

First line may be changed as - Contributors for keep sorting

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't care too much -- but if somebody want to make a PR for this you are welcome

@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants