make_mocked_request: subscriptable default app

[butla]

What do these changes do?

App in the default request created with make_mocked_request won't crash when accessed with [].

Are there changes in behavior for the user?

Nope.

Related issue number

#3134

[codecov-io]

Codecov Report

Merging #3174 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3174      +/-   ##
==========================================
+ Coverage   98.07%   98.07%   +<.01%     
==========================================
  Files          43       43              
  Lines        7853     7860       +7     
  Branches     1354     1354              
==========================================
+ Hits         7702     7709       +7     
  Misses         59       59              
  Partials       92       92

Impacted Files	Coverage Δ
aiohttp/test_utils.py	99.27% <100%> (+0.01%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99914c8...765c4eb. Read the comment docs.

[asvetlov]

The PR doesn't crash, it's true.
I wonder is it helpful?

req.app['key'] = 'val'
assert req.app['key'] == 'val'

fails.
Adding a mock for app.__getitem__ works but it looks complicated.

What do you think?

[butla]

Well, it'd be useful for some of the tests I have, where something is accessed from the app, but whatever gets accessed doesn't get used in a meaningful way for the logic.

To make it more useful I could implement __setitem__ and __getitem__ inside _create_app_mock more or less like this:

def set_dict(app, key, value):
    app.__app_dict[key] = value

def get_dict(app, key):
     return app.__app_dict[key]

app = MagicMock()
app.__app_dict = {}
app.__getitem__ = get_dict
app.__setitem__ = set_dict

[asvetlov]

yes, it is more robust

[butla]

@asvetlov I've updated the code.

[asvetlov]

Please add ca change note into CHANGES folder

[butla]

@asvetlov Added.

fixed

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new