Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 6a6ab7d and c5d399 to 3.1 #2915

Merged
merged 2 commits into from
Apr 5, 2018
Merged

Backport 6a6ab7d and c5d399 to 3.1 #2915

merged 2 commits into from
Apr 5, 2018

Conversation

pfreixes
Copy link
Contributor

@pfreixes pfreixes commented Apr 5, 2018

What do these changes do?

Backports the fix related to the #2909 issue for the 3.1 branch.

Note that due that fix was finally made using two commits the backport has been by hand but trying to keep the nomenclature imposed by cherry_picker /cc @Mariatta

@codecov-io
Copy link

codecov-io commented Apr 5, 2018

Codecov Report

Merging #2915 into 3.1 will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              3.1    #2915      +/-   ##
==========================================
+ Coverage   97.98%   97.98%   +<.01%     
==========================================
  Files          39       39              
  Lines        7499     7501       +2     
  Branches     1316     1317       +1     
==========================================
+ Hits         7348     7350       +2     
  Misses         48       48              
  Partials      103      103
Impacted Files Coverage Δ
aiohttp/http_writer.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98c7491...21773ca. Read the comment docs.

@pfreixes pfreixes merged commit db7dcb8 into 3.1 Apr 5, 2018
@pfreixes
Copy link
Contributor Author

pfreixes commented Apr 5, 2018

Releases are automatic?

@asvetlov asvetlov deleted the backport-c5d399-3.1 branch April 5, 2018 18:30
@asvetlov
Copy link
Member

asvetlov commented Apr 5, 2018

No, I should do it. Please wait for a while

@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants