Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate change entry for #1134 for 2.1.0 (2017-05-26) #1961

Merged
merged 1 commit into from
Jun 6, 2017
Merged

Remove duplicate change entry for #1134 for 2.1.0 (2017-05-26) #1961

merged 1 commit into from
Jun 6, 2017

Conversation

SoumenDass
Copy link
Contributor

@SoumenDass SoumenDass commented Jun 6, 2017

What do these changes do?

Remove duplicate change entry for #1134 for 2.1.0 (2017-05-26)

Are there changes in behavior for the user?

No

Related issue number

#1960

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • [] Add a new entry to CHANGES.rst
    • Choose any open position to avoid merge conflicts with other PRs.
    • Add a link to the issue you are fixing (if any) using #issue_number format at the end of changelog message. Use Pull Request number if there are no issues for PR or PR covers the issue only partially.

@codecov-io
Copy link

codecov-io commented Jun 6, 2017

Codecov Report

Merging #1961 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1961   +/-   ##
=======================================
  Coverage   97.05%   97.05%           
=======================================
  Files          37       37           
  Lines        7612     7612           
  Branches     1328     1328           
=======================================
  Hits         7388     7388           
  Misses        101      101           
  Partials      123      123

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d63d49...6ce1fa0. Read the comment docs.

@fafhrd91 fafhrd91 merged commit 5638865 into aio-libs:master Jun 6, 2017
@fafhrd91
Copy link
Member

fafhrd91 commented Jun 6, 2017

thanks

@SoumenDass
Copy link
Contributor Author

I'm new at this - once the merge is commited, how does it reflect in the website? In the http://aiohttp.readthedocs.io/en/stable/changes.html#id1 page, I can still see the duplicate entries even though https://github.com/aio-libs/aiohttp/blob/master/CHANGES.rst is correct.

@fafhrd91
Copy link
Member

fafhrd91 commented Jun 8, 2017

it is available in "latest", it will appear in stable in next release

@SoumenDass
Copy link
Contributor Author

thanks.

@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants