allow starting variables with an underscore

[arthurdarcet]

This allows the named resources identifiers to start with an underscore

Mongo ids are useful as a named resource in a route, but they are usually named _id and are excluded by the current regex

If this isn't an acceptable change, then the documentation should imo be updated to specify what is an acceptable route identifier ([a-zA-Z][_a-zA-Z0-9]* currently)

[codecov-io]

Current coverage is 98.78% (diff: 100%)

Merging #1379 into master will not change coverage

@@             master      #1379   diff @@
==========================================
  Files            29         29          
  Lines          6762       6762          
  Methods           0          0          
  Messages          0          0          
  Branches       1123       1123          
==========================================
  Hits           6680       6680          
  Misses           38         38          
  Partials         44         44          

Powered by Codecov. Last update 4ff21c2...abfa1be

[asvetlov]

The change is good to me.
The idea is: route variable names should accept everything that is good for python variables themselves.
Thus I'm ok even with adding non-ascii names on first demand :)

[asvetlov]

Thanks

[arthurdarcet]

Thanks, and good to know for the non-ascii names. I'll have a go a that too if I ever need it

For reference, if anyone stumble here, python identifiers are:

identifier   ::=  xid_start xid_continue*
id_start     ::=  <all characters in general categories Lu, Ll, Lt, Lm, Lo, Nl, the underscore, and characters with the Other_ID_Start property>
id_continue  ::=  <all characters in id_start, plus characters in the categories Mn, Mc, Nd, Pc and others with the Other_ID_Continue property>
xid_start    ::=  <all characters in id_start whose NFKC normalization is in "id_start xid_continue*">
xid_continue ::=  <all characters in id_continue whose NFKC normalization is in "id_continue*">

[lock]

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.