Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved #1299 - Allow StaticRoute to follow symlinks #1327

Merged
merged 6 commits into from
Oct 23, 2016
Merged

Resolved #1299 - Allow StaticRoute to follow symlinks #1327

merged 6 commits into from
Oct 23, 2016

Conversation

alexm92
Copy link
Contributor

@alexm92 alexm92 commented Oct 23, 2016

What do these changes do?

Added option on StaticRoute to follow symlinks. Example:

app.router.add_static('/static', path_to_static_dir, follow_symlinks=True)

Are there changes in behavior for the user?

No

Related issue number

#1299

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new entry to CHANGES.rst
    • Choose any open position to avoid merge conflicts with other PRs.
    • Add a link to the issue you are fixing (if any) using #issue_number format at the end of changelog message. Use Pull Request number if there are no issues for PR or PR covers the issue only partially.

@codecov-io
Copy link

codecov-io commented Oct 23, 2016

Current coverage is 98.77% (diff: 100%)

Merging #1327 into master will increase coverage by <.01%

@@             master      #1327   diff @@
==========================================
  Files            29         29          
  Lines          6521       6523     +2   
  Methods           0          0          
  Messages          0          0          
  Branches       1092       1093     +1   
==========================================
+ Hits           6441       6443     +2   
  Misses           36         36          
  Partials         44         44          

Powered by Codecov. Last update 4294067...f0ce5fa

Copy link
Member

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test.

@alexm92
Copy link
Contributor Author

alexm92 commented Oct 23, 2016

just added a test :)

@asvetlov asvetlov merged commit 1ae3ae6 into aio-libs:master Oct 23, 2016
@asvetlov
Copy link
Member

Cool! Thanks!

@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants