Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further optimize the logo/icon #5914

Merged
merged 7 commits into from
Oct 6, 2021
Merged

Conversation

ShadiestGoat
Copy link
Contributor

@ShadiestGoat ShadiestGoat commented Jul 26, 2021

What do these changes do?

The only thing this does is make further optimizations to the svg of the icon. It also changes the viewbox from 76 to 24, so that it can be used easier for projects that use tools like simple-icons

Are there changes in behavior for the user?

Not really, unless the extract the raw path data. It still has the same height & width, so should not affect users.

Related issue number

None

Checklist

Irrelevant:

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.

Relevant:

  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

It's not exactly required, but projects such as simple-icons use a 24 24 viewbox, and dont move the viewbox into the middle for no reason (instead starting at 0 0)
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jul 26, 2021
CHANGES/5914.misc Outdated Show resolved Hide resolved
@webknjaz webknjaz enabled auto-merge (squash) October 6, 2021 22:43
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@webknjaz webknjaz disabled auto-merge October 6, 2021 22:44
@webknjaz webknjaz merged commit 5fab03a into aio-libs:master Oct 6, 2021
@patchback
Copy link
Contributor

patchback bot commented Oct 6, 2021

Backport to 3.8: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 5fab03a on top of patchback/backports/3.8/5fab03a523010c0fb531c064f300e6cfe0d5b67b/pr-5914

Backporting merged PR #5914 into master

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/aio-libs/aiohttp.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/3.8/5fab03a523010c0fb531c064f300e6cfe0d5b67b/pr-5914 upstream/3.8
  4. Now, cherry-pick PR Further optimize the logo/icon #5914 contents into that branch:
    $ git cherry-pick -x 5fab03a523010c0fb531c064f300e6cfe0d5b67b
    If it'll yell at you with something like fatal: Commit 5fab03a523010c0fb531c064f300e6cfe0d5b67b is a merge but no -m option was given., add -m 1 as follows intead:
    $ git cherry-pick -m1 -x 5fab03a523010c0fb531c064f300e6cfe0d5b67b
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Further optimize the logo/icon #5914 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/3.8/5fab03a523010c0fb531c064f300e6cfe0d5b67b/pr-5914
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@aio-libs-github-bot
Copy link
Contributor

💔 Backport was not successful

The PR was attempted backported to the following branches:

  • ❌ 3.8: Commit could not be cherrypicked due to conflicts

webknjaz pushed a commit to webknjaz/aiohttp that referenced this pull request Oct 6, 2021
* Further optimized, now using viewbox of 0 0 24 24

It's not exactly required, but projects such as simple-icons use a 24 24 viewbox, and dont move the viewbox into the middle for no reason (instead starting at 0 0)

* Added color to the icon

* Update aiohttp-plain.svg

* Added same height width as original

* Update aiohttp-plain.svg

* Create 5914.misc

* Make the change note clearer

Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
(cherry picked from commit 5fab03a)
webknjaz added a commit that referenced this pull request Oct 6, 2021
* Further optimized, now using viewbox of 0 0 24 24

It's not exactly required, but projects such as simple-icons use a 24 24 viewbox, and dont move the viewbox into the middle for no reason (instead starting at 0 0)

* Added color to the icon

* Update aiohttp-plain.svg

* Added same height width as original

* Update aiohttp-plain.svg

* Create 5914.misc

* Make the change note clearer

Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
(cherry picked from commit 5fab03a)

Co-authored-by: Shady Goat <48590492+ShadiestGoat@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants