Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise TypeError when last_modified gets an unexpected type #10143

Closed
bdraco opened this issue Dec 7, 2024 · 1 comment · Fixed by #10146
Closed

Raise TypeError when last_modified gets an unexpected type #10143

bdraco opened this issue Dec 7, 2024 · 1 comment · Fixed by #10146

Comments

@bdraco
Copy link
Member

bdraco commented Dec 7, 2024

Maybe raising ValueError when it's going to do nothing does make the most sense (along with a test for it). However not sure if we should backport something like that to 3.x as the current behavior is to swallow unsupported types and raising an exception might be breaking change.

Originally posted by @bdraco in #10101 (comment)
@bdraco bdraco mentioned this issue Dec 7, 2024
Merged
bdraco added a commit that referenced this issue Dec 8, 2024
@bdraco
Raise ValueError when setting StreamResponse.last_modified to an unsu…
be95343 
…pported type

Currently this would silently fail and discard the new
value.

fixes #10143
@bdraco bdraco mentioned this issue Dec 8, 2024
Merged
@bdraco
Copy link
Member Author

bdraco commented Dec 8, 2024

Thought about it some more, and probably ok to backport to 3.12 but not 3.11

@bdraco bdraco changed the title Raise ValueError when last_modified gets an unexpected type Raise TypeError when last_modified gets an unexpected type Dec 8, 2024
patchback bot pushed a commit that referenced this issue Dec 12, 2024
@bdraco @patchback
Raise TypeError when setting StreamResponse.last_modified to an u…
f8cf09a 
…nsupported type (#10146)

<!-- Thank you for your contribution! -->

## What do these changes do?

closes #10143

## Are there changes in behavior for the user?

Currently this would silently fail and discard the new value.

<img width="685" alt="Screenshot 2024-12-08 at 12 32 49 PM"
src="https://github.com/user-attachments/assets/b0cf00c3-cd2e-4be6-af94-d993491bd296">

(cherry picked from commit a818e51)
@patchback patchback bot mentioned this issue Dec 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Raise TypeError when setting StreamResponse.last_modified to an unsupported type aio-libs/aiohttp
1 participant
@bdraco