aiohttp in 'async with' along with existing websocket app

[schiebel]

Hello,

I'm trying to add a simple aiohttp server as part of a larger Bokeh app which uses websockets. I tried to add the simple aiohttp server to a serve member function like:

async def hello(request):
    return web.Response(text="Hello, world")
app = web.Application()
app.add_routes([web.get('/', hello)])

async with websockets.serve( self._pipe['control'].process_messages, self._pipe['control'].address[0], self._pipe['control'].address[1] ) as ctrl, \
           websockets.serve( self._pipe['converge'].process_messages, self._pipe['converge'].address[0], self._pipe['converge'].address[1] ) as conv, \
           self._cube.serve( self.__stop ) as cube, asyncio.coroutine(web._run_app( app, port=8000 )) as http:
    self.__result_future = asyncio.Future( )
    yield ( self.__result_future, { 'ctrl': ctrl, 'conv': conv, 'cube': cube, 'http': http } )

This tuple yielded from serve( ) is then run like:

async def _run_( ):
    async with self.serve( ) as s:
        await s[0]

if self._is_notebook:
    ic_task = asyncio.create_task(_run_())
else:
    asyncio.run(_run_( ))
    return self.result( )

...where s[0] is the self.__result_future yielded above. The Bokeh GUI then sets the self.__result_future via a socket when the GUI interaction is complete. The addition of the web._runapp(...) coroutine results in this error:

apps/_interactiveclean.py:1199: RuntimeWarning: coroutine '_run_app' was never awaited
  async with websockets.serve( self._pipe['control'].process_messages, self._pipe['control'].address[0], self._pipe['control'].address[1] ) as ctrl, \
Traceback (most recent call last):
  File "tests/manual/iclean-demo-py310/run-iclean.py", line 61, in <module>
    res = ic()
  File "tests/manual/iclean-demo-py310/casagui/apps/_interactiveclean.py", line 1121, in __call__
    asyncio.run(_run_( ))
  File "lib/python3.10/asyncio/runners.py", line 44, in run
    return loop.run_until_complete(main)
  File "lib/python3.10/asyncio/base_events.py", line 649, in run_until_complete
    return future.result()
  File "tests/manual/iclean-demo-py310/casagui/apps/_interactiveclean.py", line 1115, in _run_
    async with self.serve( ) as s:
  File "lib/python3.10/contextlib.py", line 199, in __aenter__
    return await anext(self.gen)
  File "tests/manual/iclean-demo-py310/casagui/apps/_interactiveclean.py", line 1199, in serve
    async with websockets.serve( self._pipe['control'].process_messages, self._pipe['control'].address[0], self._pipe['control'].address[1] ) as ctrl, \
AttributeError: __aenter__

Can anyone offer any advice on how to mix a aiohttp Application service in with exiting asyncio semantics?

Thanks in advance for any advice...

[Dreamsorcerer]

Yes, don't use private, undocumented functions which we'll break later.

Instead, either create an aiohttp application that runs the other parts of your application in cleanup_ctx as per the documentation:
https://docs.aiohttp.org/en/stable/web_advanced.html#complex-applications
Or use the app runners:
https://docs.aiohttp.org/en/stable/web_advanced.html#application-runners

[schiebel]

Thanks very much for the reply! The app runner works great.