Disable back aiodns by default

aio-libs · Nov 1, 2016 · 9fbb7d7 · 9fbb7d7
1 parent bcd9b95
commit 9fbb7d7
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 7 deletions.
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -93,7 +93,7 @@ CHANGES
 - Extend `ClientResponse` with `content_type` and `charset`
   properties like in `web.Request`. #1349
 
--
+- Disable aiodns by default #559
 
 -
 

diff --git a/aiohttp/resolver.py b/aiohttp/resolver.py
@@ -7,10 +7,11 @@
 
 try:
     import aiodns
-    aiodns_default = hasattr(aiodns.DNSResolver, 'gethostbyname')
+    # aiodns_default = hasattr(aiodns.DNSResolver, 'gethostbyname')
 except ImportError:  # pragma: no cover
     aiodns = None
-    aiodns_default = False
+
+aiodns_default = False
 
 
 class ThreadedResolver(AbstractResolver):

diff --git a/tests/test_resolver.py b/tests/test_resolver.py
@@ -203,7 +203,8 @@ def test_async_resolver_aiodns_not_present(loop, monkeypatch):
 
 
 def test_default_resolver():
-    if gethostbyname:
-        assert DefaultResolver is AsyncResolver
-    else:
-        assert DefaultResolver is ThreadedResolver
+    # if gethostbyname:
+    #     assert DefaultResolver is AsyncResolver
+    # else:
+    #     assert DefaultResolver is ThreadedResolver
+    assert DefaultResolver is ThreadedResolver