Fix a warning about unfinished task in web_protocol.py (#4415)

aio-libs · Oct 21, 2020 · 6319c25 · 6319c25
1 parent d321923
commit 6319c25
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/CHANGES/4408.bugfix b/CHANGES/4408.bugfix
@@ -0,0 +1 @@
+Fix a warning about unfinished task in `web_protocol.py`
diff --git a/aiohttp/web_protocol.py b/aiohttp/web_protocol.py
@@ -277,6 +277,10 @@ def connection_lost(self, exc: Optional[BaseException]) -> None:
 
         if self._error_handler is not None:
             self._error_handler.cancel()
+        if self._task_handler is not None:
+            self._task_handler.cancel()
+        if self._waiter is not None:
+            self._waiter.cancel()
 
         self._task_handler = None
 

diff --git a/tests/test_web_protocol.py b/tests/test_web_protocol.py
@@ -821,7 +821,7 @@ async def disconn():
     writer.write(b"x")
     writer.close()
     await asyncio.sleep(0.1)
-    logger.debug.assert_called_with('Ignored premature client disconnection.')
+    logger.debug.assert_called_with('Ignored premature client disconnection')
     assert disconnected_notified