-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement new_session functionality #282
Conversation
Explicitly request new session
Codecov Report
@@ Coverage Diff @@
## master #282 +/- ##
==========================================
+ Coverage 96.92% 97.08% +0.16%
==========================================
Files 4 4
Lines 195 206 +11
Branches 23 25 +2
==========================================
+ Hits 189 200 +11
Misses 4 4
Partials 2 2
Continue to review full report at Codecov.
|
I decided to make If there's on objection with that implementation (i.e. you'd prefer to have it as a coroutine for uniformity with |
I prefer a coroutine.
|
Ok, I'll make the change (code and docs) in the evening :) |
Should be good now. Let me know if any further changes are required :) |
Thanks. |
Closes #281 .
Implements new_session functionality,
Update documentation to include new function.
Update demo code to use new_session for login view.