-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
session.created property #14
Conversation
At first I very appreciate your contribution.
where current
|
Thanks for your review. I will rewrite that feature. |
Can you check my PR again, please? |
self._created = created | ||
|
||
if session_data is not None: | ||
self._mapping.update(session_data) | ||
|
||
def __repr__(self): | ||
return '<{} [new:{}, changed:{}] {!r}>'.format( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add created
info to the repr.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, i'l do it
…time when session was created
…ode according review
I made fixes from your comments |
Thanks! |
Issue #4: Add created property with timestamp indicating the time when session was created