-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump codecov/codecov-action from 3 to 4 #804
Bump codecov/codecov-action from 3 to 4 #804
Conversation
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3 to 4. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v3...v4) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
@webknjaz Can we use an organisation secret, to avoid managing a token in every repository? |
@Dreamsorcerer i considered it, but when I checked, I realized the tokens are per repo |
Anyway, I wouldn't rush to update it just yet |
Pull request was converted to draft
Appears there is an org token available: |
@webknjaz I've added an org token, this seems to be working. So, this looks good to me. I think the problems you had on multidict are also not relevant to the way other repositories are setup today. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #804 +/- ##
=======================================
Coverage 98.33% 98.33%
=======================================
Files 7 7
Lines 541 541
Branches 53 53
=======================================
Hits 532 532
Misses 9 9 ☔ View full report in Codecov by Sentry. |
@Dreamsorcerer fair. Have you made sure this secret is also available to Dependabot runs? It has separate secrets in the repo settings, not sure if you can set it on the org level. |
Will pay attention to the next PR. Though Dependabot is unlikely to affect coverage anyway. |
@Dreamsorcerer here's how it breaks: https://github.com/aio-libs/aiohttp-jinja2/actions/runs/7866487264/job/21460826217#step:7:34 |
@Dreamsorcerer could you duplicate that token @ https://github.com/organizations/aio-libs/settings/secrets/dependabot ? |
Nevermind. Just did it myself and restarted one job in that workflow run to verify. |
Yep, that fixed it: https://github.com/aio-libs/aiohttp-jinja2/actions/runs/7866487264/job/21461295199#step:7:35. Restarting the rest of the failing jobs now. |
Bumps codecov/codecov-action from 3 to 4.
Release notes
Sourced from codecov/codecov-action's releases.
... (truncated)
Changelog
Sourced from codecov/codecov-action's changelog.
... (truncated)
Commits
f30e495
fix: update action.yml (#1240)a7b945c
fix: allow for other archs (#1239)98ab2c5
Update package.json (#1238)43235cc
Update README.md (#1237)0cf8684
chore(ci): bump to node20 (#1236)8e1e730
build(deps-dev): bump@typescript-eslint/eslint-plugin
from 6.19.1 to 6.20.0 ...61293af
build(deps-dev): bump@typescript-eslint/parser
from 6.19.1 to 6.20.0 (#1235)7a070cb
build(deps): bump github/codeql-action from 3.23.1 to 3.23.2 (#1231)9097165
build(deps): bump actions/upload-artifact from 4.2.0 to 4.3.0 (#1232)ac042ea
build(deps-dev): bump@typescript-eslint/eslint-plugin
from 6.19.0 to 6.19.1 ...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)