Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix page rendering #46 #48

Merged
merged 2 commits into from
Sep 26, 2016
Merged

Fix page rendering #46 #48

merged 2 commits into from
Sep 26, 2016

Conversation

jettify
Copy link
Member

@jettify jettify commented Sep 25, 2016

@samuelcolvin this PR should fix #46 could you review my changes?

@coveralls
Copy link

coveralls commented Sep 26, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.04%) to 85.671% when pulling 9465143 on fix-rendering into 3f71ba7 on master.

samuelcolvin
samuelcolvin approved these changes Sep 26, 2016
View reviewed changes
Copy link
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried locally and problem seems fixed.

@jettify jettify merged commit 8ca719f into master Sep 26, 2016
@asvetlov
Copy link
Member

@jettify please feel free to make a new release when ready.
Travis should do all dirty job, the only new git tag is required.

@asvetlov asvetlov deleted the fix-rendering branch September 26, 2016 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelcolvin samuelcolvin samuelcolvin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FIXME fouc
5 participants
@jettify @coveralls @asvetlov @samuelcolvin @nickolai-dr