Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependencies #1246

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jakob-keller
Copy link
Collaborator

Description of Change

Add missing runtime and dev dependencies.

Assumptions

All direct dependencies (i.e. used by codebase) should be specified as such.

Checklist for All Submissions

  • I have added change info to CHANGES.rst
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details):
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details):
    • Detailed description of new feature
    • Why needed
    • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

  • I have read and followed CONTRIBUTING.rst
  • I have updated test_patches.py where/if appropriate (also check if no changes necessary)
  • I have ensured that the awscli/boto3 versions match the updated botocore version

@jakob-keller jakob-keller added the dependencies Pull requests that update a dependency file label Dec 29, 2024
@jakob-keller jakob-keller self-assigned this Dec 29, 2024
Copy link

codecov bot commented Dec 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.07%. Comparing base (24108bf) to head (10a2fbd).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1246      +/-   ##
==========================================
- Coverage   88.16%   88.07%   -0.09%     
==========================================
  Files          67       67              
  Lines        5904     5904              
==========================================
- Hits         5205     5200       -5     
- Misses        699      704       +5     
Flag Coverage Δ
unittests 88.07% <100.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

requirements-dev.in Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@jakob-keller
Copy link
Collaborator Author

Maybe we should also update the Requirements section in README. Is that even necessary? It feels a bit redundant to me.

pyproject.toml Outdated Show resolved Hide resolved
requirements-dev.in Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants