AioStubber that returns AioAWSResponse()

[takeda]

Description of Change

Adding AioStubber to provide async version (responding with AioAWSResponse()) of Stubber.

Hopefully solving issue raised in #939

Checklist for All Submissions

• I have added change info to CHANGES.rst
• If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details):
  • Detailed description of issue
  • Alternative methods considered (if any)
  • How issue is being resolved
  • How issue can be reproduced
• If this is providing a new feature (can be provided via link to issue with these details):
  • Detailed description of new feature
  • Why needed
  • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

• I have read and followed CONTRIBUTING.rst
• I have updated test_patches.py where/if appropriate (also check if no changes necessary)
• I have ensured that the awscli/boto3 versions match the updated botocore version

[thehesiod]

need to add entry to test_patches

[takeda]

@thehesiod updated

[takeda]

@thehesiod I just realized that the CI tasks expect version to be provided, I did not do it because I thought that will be done after the PR is merged. I just updated the PR to include a version.

[takeda]

@thehesiod please run it again

[takeda]

@thehesiod I fixed the formatting and flake8 now doesn't report issues.

[takeda]

sigh I wonder what will fail this time

[codecov]

Codecov Report

Merging #1039 (b174eac) into master (9c6db8a) will increase coverage by 0.14%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1039      +/-   ##
==========================================
+ Coverage   86.23%   86.38%   +0.14%     
==========================================
  Files          58       60       +2     
  Lines        5740     5803      +63     
==========================================
+ Hits         4950     5013      +63     
  Misses        790      790              

Flag	Coverage Δ
unittests	86.38% <100.00%> (+0.14%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
aiobotocore/stub.py	100.00% <100.00%> (ø)
tests/test_patches.py	95.91% <100.00%> (ø)
tests/test_stubber.py	100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[takeda]

@thehesiod sorry for delay, but I had other things I needed to finish. I added some unit tests now.

[takeda]

@thehesiod can you run the pipeline again?

[takeda]

@thehesiod I rebased the PR due to another PR that was merged recently

[thehesiod]

whoops, forgot about this pr, thanks

[takeda]

@thehesiod I see it failed, but it looks like it was during uploading the results to codecov?

[takeda]

The codecov still makes nos sense, coverage told me the coverage is 100%, looking at codecov I see for example this (line 15):

https://github.com/aio-libs/aiobotocore/pull/1039/files#annotation_15037531067

But that line is always executed, so I don't see how it wouldn't be covered.

[thehesiod]

The codecov still makes nos sense, coverage told me the coverage is 100%, looking at codecov I see for example this (line 15):

https://github.com/aio-libs/aiobotocore/pull/1039/files#annotation_15037531067

But that line is always executed, so I don't see how it wouldn't be covered.

you need to add the moto marker to your tests, we only run things marked with moto. what would be better going forward is instead having a marker for tests that require a real AWS account, and then exclude those if you want to attempt that. This has bit us a couple times with new contributors.

[thehesiod]

looks like you can do this with pytest -m "not MARKER"

[takeda]

@thehesiod I added the marker, I didn't use it, since stubber overlaps with functionality so I felt it was redundant.