Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Prevents long waiting times when connecting to incorrect or unresponsive addresses #3185

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

zhiyxu
Copy link
Contributor

@zhiyxu zhiyxu commented Jul 11, 2024

Currently, when making HTTP requests using requests.get, there is no timeout specified. This can lead to long waiting times (up to 2 minutes) during the protocol_probe process when connecting to incorrect or unresponsive addresses. This delay is due to the default TCP SYN-SENT timeout.

image

Add a default timeout parameter to all requests.get calls to allow for fast failure and better error handling in network operations.

@CLAassistant
Copy link

CLAassistant commented Jul 11, 2024

CLA assistant check
All committers have signed the CLA.

@zhiyxu
Copy link
Contributor Author

zhiyxu commented Jul 11, 2024

@mihran113 @alberttorosyan @SGevorg Could you please help checking the pr, thanks in advance!

@mihran113 mihran113 self-requested a review July 11, 2024 10:38
@mihran113
Copy link
Contributor

Hey @zhiyxu! Thanks a lot for opening the PR. Everything looks good. Just one ask: could you please also add an entry to changelog?

@zhiyxu
Copy link
Contributor Author

zhiyxu commented Jul 11, 2024

Hey @zhiyxu! Thanks a lot for opening the PR. Everything looks good. Just one ask: could you please also add an entry to changelog?

Thanks for your quick reply, changelog is updated.

BTW, what is the release cadence of the project, and when will the next version be released?

@mihran113
Copy link
Contributor

mihran113 commented Jul 11, 2024

Hey @zhiyxu! Thanks a lot for opening the PR. Everything looks good. Just one ask: could you please also add an entry to changelog?

Thanks for your quick reply, changelog is updated.

BTW, what is the release cadence of the project, and when will the next version be released?

We try to ship releases at least twice a month, but mainly depends on the features completed.
There's one more PR that I've asked for some changes and we'll release the next version, so tomorrow or (worst case scenario) Monday the new release will be shipped.

@zhiyxu
Copy link
Contributor Author

zhiyxu commented Jul 12, 2024

Hey @zhiyxu! Thanks a lot for opening the PR. Everything looks good. Just one ask: could you please also add an entry to changelog?

Thanks for your quick reply, changelog is updated.
BTW, what is the release cadence of the project, and when will the next version be released?

We try to ship releases at least twice a month, but mainly depends on the features completed. There's one more PR that I've asked for some changes and we'll release the next version, so tomorrow or (worst case scenario) Monday the new release will be shipped.

There's still a failure in unit tests, could you please help to check and merge the commit, it would be great if this commit could be included in the next release.

@mihran113
Copy link
Contributor

Hey @zhiyxu! Thanks a lot for opening the PR. Everything looks good. Just one ask: could you please also add an entry to changelog?

Thanks for your quick reply, changelog is updated.
BTW, what is the release cadence of the project, and when will the next version be released?

We try to ship releases at least twice a month, but mainly depends on the features completed. There's one more PR that I've asked for some changes and we'll release the next version, so tomorrow or (worst case scenario) Monday the new release will be shipped.

There's still a failure in unit tests, could you please help to check and merge the commit, it would be great if this commit could be included in the next release.

It's the performance tests, it's failing currently for all the commits, and none of your changes affecting those parts, so I'll merge the commit 🎉

@mihran113 mihran113 merged commit dd246b3 into aimhubio:main Jul 12, 2024
2 of 3 checks passed
@mihran113
Copy link
Contributor

Hey @zhiyxu! The new version of aim has been shipped (3.23.0) which includes the changes made with this PR. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants