Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Bookmarks page cannot scroll #3184

Merged
merged 3 commits into from
Jul 17, 2024

Conversation

vinayan3
Copy link
Contributor

This is a fix for #2653.
The bookmarks page was not scrolling because the container CSS doesn't have overflow-y: auto. To make the page scroll
the container CSS class was removed and wrapper div was added which is sets to the height of the viewport. The screenshot below show the page scrolling for the bookmarks. The appBar is no longer in a fixed position otherwise the top of the scroll bar is hidden by the appbar.

Scrolling bookmarks:
Screenshot from 2024-07-10 18-02-29

@CLAassistant
Copy link

CLAassistant commented Jul 11, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@mihran113
Copy link
Contributor

Hey @vinayan3! Thanks a lot for opening the PR! The changes look good. Could you please sign the CLA and also add an entry in changelog (under the unreleased section) so I can proceed to merge the PR?

@vinayan3
Copy link
Contributor Author

@mihran113 I'm contributing as part of my time at work therefore, my company requires that someone from the legal team sign the CLA. Do you if the CLA assistant allows for this workflow where a designated signatory of a company signs on behalf of people from that organization?

@mihran113
Copy link
Contributor

@mihran113 I'm contributing as part of my time at work therefore, my company requires that someone from the legal team sign the CLA. Do you if the CLA assistant allows for this workflow where a designated signatory of a company signs on behalf of people from that organization?

@vinayan3 unfortunately the current CLAassistant doesn't allow for anyone else other than the PR author to sign the CLA. @SGevorg any ideas how we can tackle this?

@vinayan3
Copy link
Contributor Author

vinayan3 commented Jul 11, 2024

@mihran113 I'm contributing as part of my time at work therefore, my company requires that someone from the legal team sign the CLA. Do you if the CLA assistant allows for this workflow where a designated signatory of a company signs on behalf of people from that organization?

@vinayan3 unfortunately the current CLAassistant doesn't allow for anyone else other than the PR author to sign the CLA. @SGevorg any ideas how we can tackle this?

I believe you are using the cla-assistant and from their github I found these tickets:

Could you see if your instace / usage of the CLA assistant allows for this?

If so my company has a public Github org Aurora Open Source](https://github.com/aurora-opensource) which I'm apart of. I can make myself public too.

If we can sig the CLA offline like through email would this work?

Finally, if you want to chat I'm on your public Discord. You can DM there.

@SGevorg
Copy link
Member

SGevorg commented Jul 12, 2024

Hi @vinayan3 after thinking a bit, here is what I propose to move forward..
For us to be able to merge this PR, the CLA must be signed from your user technically.

However for this to make legal sense, please share this URL with your legal team to sign as well.
https://cla-assistant.io/aimhubio/aim
You still will need to do it with a github account if you want to do it online.
Alternatively, you can online sign the legal doc (docusign) that's available in that link and send to hello@aimhub.io. That would do the job too.
Do you think this would work?

In the worst case scenario, we will override thie PR and just merge it ourselves. But this is not what we would prefer to do as we love contributions.

@vinayan3
Copy link
Contributor Author

Hi @vinayan3 after thinking a bit, here is what I propose to move forward.. For us to be able to merge this PR, the CLA must be signed from your user technically.

However for this to make legal sense, please share this URL with your legal team to sign as well. https://cla-assistant.io/aimhubio/aim You still will need to do it with a github account if you want to do it online. Alternatively, you can online sign the legal doc (docusign) that's available in that link and send to hello@aimhub.io. That would do the job too. Do you think this would work?

In the worst case scenario, we will override thie PR and just merge it ourselves. But this is not what we would prefer to do as we love contributions.

I have signed and can then continue with this PR.

@vinayan3
Copy link
Contributor Author

@mihran113 ready for review!

@mihran113
Copy link
Contributor

Hey @vinayan3! Thanks a lot for your contribution, everything looks good, proceeding to merge 🎉

@mihran113 mihran113 merged commit d7fb170 into aimhubio:main Jul 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants