Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Add feature to delete full experiments #3158

Merged
merged 7 commits into from
Jun 11, 2024

Conversation

mauricekraus
Copy link
Contributor

This pull request introduces the ability to delete entire experiments directly from the user interface.

Key Changes:

Delete Full Experiments:

Users can now delete entire experiments without having to manually select and delete individual runs.
This resolves the issue of having empty experiments after all runs are deleted, providing a more streamlined workflow.
Delete all runs of an experiment:

UI Consistency:

image

The delete functionality for experiments is currently available only on the experiment settings tab, making it consistent with the existing run detail deletion process.

How we should delete experiments from the dashboard needs further discussion (due to the space constraints)

Issues Resolved:
Closes #2528 , #2803

@mihran113
Copy link
Contributor

Hey @mauricekraus! Thanks for opening the PR. the UI side looks great! But deleting the runs from BE side is a bit more complicated process as seen here:

def _delete_run(self, run_hash):

I guess, there will be a need to go over the experiment runs in a loop and delete them separately. It would be great if you can make those changes.

@mauricekraus
Copy link
Contributor Author

Sure, thanks for the heads up, i totally missed the remote part as well as the rockdb stuff.

@mihran113
Copy link
Contributor

Handling the remote part is unnecessary in this case cause repo will be local for the UI anyways. (It's for handling the run deletions from CLI and SDK)

@mauricekraus
Copy link
Contributor Author

@mihran113 this should resolve it, however, I'm still not sure about the remote thingy, at least locally this implementation gets rid of all runs in an experiment.

@mihran113
Copy link
Contributor

mihran113 commented Jun 10, 2024

Hey @mauricekraus! Thank a lot for the changes. This should do the job. Regarding the remote: don't worry about it, I'll add that in the future when there'll be a need.
I'll run some tests to see if everything works fine and merge the PR. In the meanwhile can I ask you to change the destination branch to the aihmhubio:main and update the changelog like this:

## Unreleased

### Enhancements:
- Add feature to delete full experiments (mauricekraus)

And also would be great if you would address some code style issues here:
https://github.com/aimhubio/aim/actions/runs/9455877092/job/26047473072

@mihran113 mihran113 changed the title Add Feature to Delete Full Experiments [feat] Add feature to delete full experiments Jun 10, 2024
@mauricekraus mauricekraus changed the base branch from release/3.20.x to main June 10, 2024 22:42
Copy link
Contributor

@mihran113 mihran113 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Thanks a lot for the contribution. I've run some tests, everything looks fine! 🎉

@mihran113 mihran113 merged commit dc0baaf into aimhubio:main Jun 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete experiments from UI
2 participants