-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Add a filesystem-based backend for artifact storage #3156
Conversation
|
I was interested in this, and saw a few issues (#3144, #3139) mentioning it as well, so I thought I'd see if I could implement it. It seems to be working in my very simple setup, but I haven't done that much testing. Curious for feedback from maintainers as to whether this looks like the correct approach or not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gpascale the changes look good! I've tested them and found no issues.
Would you mind updating the CHANGELOG.md
file to reflect the changes and sign the CLA agreement?
We can proceed with the merge right after that
@gpascale I've pushed changes in |
@alberttorosyan Ah sorry for going dark on this. I was travelling the past few weeks and not checking things. Glad to heard you've gotten the feature in! |
Adds
FilesystemArtifactStorage
, a local filesystem-backed implementation ofAbstractArtifactStorage
, and adds it to the registry.Works very similarly to S3ArtifactStorage, except you would pass a url like
file:///path/to/artifacts
as the uri.