[feat] Allow HF callback to initialize Aim run at init end #3116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hey @dushyantbehl. Thanks for your contribution 🙌
Changes look good!
Would you mind updating the CHANGELOG.md file according to the changes?
alberttorosyan
changed the title
|
@alberttorosyan sure! |
Signed-off-by: Dushyant Behl <dushyantbehl@users.noreply.github.com>
Signed-off-by: Dushyant Behl <dushyantbehl@users.noreply.github.com>
|
@alberttorosyan done with the changes, let me know if I need to change anything. 🥂 |
alberttorosyan
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation of HF callback in Aim initializes the
Runobject at training begin time. This means if the users want to track any additional metrics they need to do so before training finishes while usingHFTrainerobject.This small change which initializes the
Runobject oninit_endmakes the run object available to user of this callback viacallback.experimentand allows them to track any extra metrics or parameters with the same run other than the standard metrics output by HF.