Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Avoid saving crashed or terminated search requests as the last state on explorers #1950

Merged
merged 4 commits into from
Jul 7, 2022
Merged

[fix] Avoid saving crashed or terminated search requests as the last state on explorers #1950

merged 4 commits into from
Jul 7, 2022

Conversation

arsengit
Copy link
Contributor

@arsengit arsengit commented Jul 7, 2022

  • Update URL after getting a valid response from the back-end.
  • Fix decoding issue related to BS64_ENCODING_PADDING padding.

@arsengit arsengit self-assigned this Jul 7, 2022
@arsengit
Copy link
Contributor Author

arsengit commented Jul 7, 2022

Resolves #1924

KaroMourad
KaroMourad approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@KaroMourad KaroMourad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@arsengit arsengit force-pushed the fix/avoid-saving-crashed-queries branch from 20f7623 to c8da5ff Compare July 7, 2022 19:17
@arsengit arsengit merged commit e1a2f65 into release/3.11.x Jul 7, 2022
@arsengit arsengit deleted the fix/avoid-saving-crashed-queries branch July 7, 2022 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roubkar roubkar roubkar approved these changes

@KaroMourad KaroMourad KaroMourad approved these changes

Assignees

@arsengit arsengit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arsengit @roubkar @KaroMourad