Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Handle generic Exceptions and adjust HTTPException handling #1933

Merged
merged 3 commits into from
Jul 8, 2022
Merged

[fix] Handle generic Exceptions and adjust HTTPException handling #1933

merged 3 commits into from
Jul 8, 2022

Conversation

alberttorosyan
Copy link
Member

Added new error handler to cover all Exception sub-classes. Used as a fallback
Handle case when no 'detail' is available

@alberttorosyan
Copy link
Member Author

resolves #1818

mihran113
mihran113 approved these changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@mihran113 mihran113 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mihran113 mihran113 merged commit fc39d0a into release/3.11.x Jul 8, 2022
@mihran113 mihran113 deleted the fix/more-descriptive-error-messages branch July 8, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihran113 mihran113 mihran113 approved these changes

@mahnerak mahnerak Awaiting requested review from mahnerak

@gorarakelyan gorarakelyan Awaiting requested review from gorarakelyan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alberttorosyan @mihran113