Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Fix the "matched runs" sentence color style overriding issue in progress bars #1931

Merged
merged 4 commits into from
Jul 1, 2022
Merged

[fix] Fix the "matched runs" sentence color style overriding issue in progress bars #1931

merged 4 commits into from
Jul 1, 2022

Conversation

KaroMourad
Copy link
Contributor

@KaroMourad KaroMourad commented Jun 30, 2022 •
edited
Loading

  • Progress bar matched runs color style overrides from main.css chunk in the production build
  • Add success styles on Text component
  • Fix Something went wrong issue in the PopoverContent component

@KaroMourad KaroMourad requested a review from roubkar June 30, 2022 08:23
@KaroMourad KaroMourad self-assigned this Jun 30, 2022
@KaroMourad KaroMourad requested review from rubenaprikyan and arsengit and removed request for roubkar June 30, 2022 08:27
@KaroMourad
Copy link
Contributor Author

KaroMourad commented Jun 30, 2022 •
edited
Loading

Resolves #1932

@KaroMourad KaroMourad force-pushed the fix/progress-bar-matched-runs-color-style branch from 39dac35 to 27f6779 Compare June 30, 2022 11:33
rubenaprikyan
rubenaprikyan approved these changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@rubenaprikyan rubenaprikyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@KaroMourad KaroMourad changed the title [fix] Fix progress bar matched runs color style overriding issue [fix] Fix progress bar matched runs color style overriding issue Jun 30, 2022
@KaroMourad KaroMourad changed the title [fix] Fix progress bar matched runs color style overriding issue [fix] Fix the "matched runs" sentence color style overriding issue in progress bars Jun 30, 2022
arsengit
arsengit approved these changes Jul 1, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@KaroMourad KaroMourad merged commit bbcc49c into release/3.11.x Jul 1, 2022
@KaroMourad KaroMourad deleted the fix/progress-bar-matched-runs-color-style branch July 1, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubenaprikyan rubenaprikyan rubenaprikyan approved these changes

@arsengit arsengit arsengit approved these changes

Assignees

@KaroMourad KaroMourad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KaroMourad @rubenaprikyan @arsengit