Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Fix the loading logic of the monaco editor across the Aim Ui #1909

Merged
merged 3 commits into from
Jun 27, 2022
Merged

[fix] Fix the loading logic of the monaco editor across the Aim Ui #1909

merged 3 commits into from
Jun 27, 2022

Conversation

arsengit
Copy link
Contributor

  • Load monaco editor from the node modules instead of CDN across the Aim Ui

@arsengit arsengit requested a review from VkoHov June 27, 2022 11:45
@arsengit
Merge branch 'release/3.11.x' into fix/laod-monaco-editor-from-node-m…
4023b19 
…odules-instead-of-cdn

# Conflicts:
#	CHANGELOG.md
VkoHov
VkoHov approved these changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@VkoHov VkoHov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@arsengit arsengit self-assigned this Jun 27, 2022
@arsengit arsengit merged commit c7088f1 into release/3.11.x Jun 27, 2022
@arsengit arsengit deleted the fix/laod-monaco-editor-from-node-modules-instead-of-cdn branch June 27, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VkoHov VkoHov VkoHov approved these changes

Assignees

@arsengit arsengit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arsengit @VkoHov