[refactor] Improve performance of dict flattening for board runs (#2891)

aimhubio · Jul 5, 2023 · c158218 · c158218
1 parent 5abdc43
commit c158218
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/pkgs/aimstack/asp/boards/run.py b/pkgs/aimstack/asp/boards/run.py
@@ -27,14 +27,14 @@ def memoize_query(cb, query):
 
 @memoize
 def flatten(dictionary, parent_key='', separator='.'):
-    items = []
+    flattened = {}
     for key, value in dictionary.items():
-        new_key = parent_key + separator + key if parent_key else key
+        new_key = f"{parent_key}{separator}{key}" if parent_key else key
         if isinstance(value, MutableMapping):
-            items.extend(flatten(value, new_key, separator=separator).items())
+            flattened.update(flatten(value, new_key, separator=separator))
         else:
-            items.append((new_key, value))
-    return dict(items)
+            flattened[new_key] = value
+    return flattened
 
 
 @memoize

diff --git a/pkgs/aimstack/asp/boards/runs.py b/pkgs/aimstack/asp/boards/runs.py
@@ -9,14 +9,14 @@
 
 
 def flatten(dictionary, parent_key='', separator='.'):
-    items = []
+    flattened = {}
     for key, value in dictionary.items():
-        new_key = parent_key + separator + key if parent_key else key
+        new_key = f"{parent_key}{separator}{key}" if parent_key else key
         if isinstance(value, MutableMapping):
-            items.extend(flatten(value, new_key, separator=separator).items())
+            flattened.update(flatten(value, new_key, separator=separator))
         else:
-            items.append((new_key, value))
-    return dict(items)
+            flattened[new_key] = value
+    return flattened
 
 
 @memoize