[fix] Remove error message on explorer unmount (#1953)

aimhubio · Jul 7, 2022 · 5ed8d8f · 5ed8d8f
1 parent 0469c07
commit 5ed8d8f
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 1 deletion.
diff --git a/aim/web/ui/src/pages/Params/components/SelectForm/SelectForm.tsx b/aim/web/ui/src/pages/Params/components/SelectForm/SelectForm.tsx
@@ -118,7 +118,6 @@ function SelectForm({
 
   const open: boolean = !!anchorEl;
   const id = open ? 'select-metric' : undefined;
-  console.log(selectedParamsData);
   return (
     <ErrorBoundary>
       <div className='SelectForm__container'>

diff --git a/aim/web/ui/src/services/models/explorer/createAppModel.ts b/aim/web/ui/src/services/models/explorer/createAppModel.ts
@@ -721,6 +721,11 @@ function createAppModel(appConfig: IAppInitialConfig) {
         queryIsEmpty: true,
         rawData: [],
         tableColumns: [],
+        selectFormData: {
+          ...model.getState().selectFormData,
+          error: null,
+          advancedError: null,
+        },
         selectedRows: shouldResetSelectedRows
           ? {}
           : model.getState()?.selectedRows,
@@ -2948,6 +2953,13 @@ function createAppModel(appConfig: IAppInitialConfig) {
         runsRequestRef.abort();
         liveUpdateInstance?.clear();
         liveUpdateInstance = null; //@TODO check is this need or not
+        model.setState({
+          ...model.getState(),
+          selectFormData: {
+            ...model.getState().selectFormData,
+            error: null,
+          },
+        });
       }
 
       function changeLiveUpdateConfig(config: {
@@ -3419,6 +3431,7 @@ function createAppModel(appConfig: IAppInitialConfig) {
           queryIsEmpty: true,
           rawData: [],
           tableColumns: [],
+          selectFormData: { ...model.getState().selectFormData, error: null },
           selectedRows: shouldResetSelectedRows
             ? {}
             : model.getState()?.selectedRows,
@@ -5775,6 +5788,10 @@ function createAppModel(appConfig: IAppInitialConfig) {
           queryIsEmpty: true,
           rawData: [],
           tableColumns: [],
+          selectFormData: {
+            ...model.getState().selectFormData,
+            error: null,
+          },
           selectedRows: shouldResetSelectedRows
             ? {}
             : model.getState()?.selectedRows,

diff --git a/aim/web/ui/src/services/models/imagesExplore/imagesExploreAppModel.ts b/aim/web/ui/src/services/models/imagesExplore/imagesExploreAppModel.ts
@@ -298,6 +298,11 @@ function resetModelState() {
   model.setState({
     ...model.getState(),
     data: [],
+    selectFormData: {
+      ...model.getState().selectFormData,
+      error: null,
+      advancedError: null,
+    },
     params: [],
     imagesData: {},
     tableData: [],