Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Missing Local Resources Checker" needs reference counter #42

Closed
gernotstarke opened this issue Oct 25, 2014 · 1 comment
Closed

"Missing Local Resources Checker" needs reference counter #42

gernotstarke opened this issue Oct 25, 2014 · 1 comment
Assignees
@gernotstarke

Comments

@gernotstarke
Copy link
Member

the same missing resource is reported multiple times, e.g.:

local resource "api/griffon/core/env/Metadata.html" missing
local resource "api/griffon/core/env/Metadata.html" missing
local resource "api/griffon/core/env/Feature.html" missing
local resource "api/griffon/core/env/Feature.html" missing
local resource "api/griffon/core/env/Metadata.html" missing
local resource "api/griffon/core/env/Metadata.html" missing

Should better be:
local resource "api/griffon/core/env/Metadata.html" missing (reference count: 4)
local resource "api/griffon/core/env/Feature.html" missing (reference count: 2)
@gernotstarke gernotstarke self-assigned this Oct 25, 2014
@gernotstarke
Copy link
Member Author

shall produce output similar to other checkers:

2 missing id found.

link target "nowhere" missing (reference count 1)   
link target "duplicate" missing (reference count 1)

@gernotstarke gernotstarke changed the title "Missing Local Resources Checker" does not detect duplicate findings "Missing Local Resources Checker" needs reference counter Oct 31, 2014
@gernotstarke gernotstarke added this to the 0.8.0 milestone Dec 13, 2014
@gernotstarke gernotstarke removed the bug label Dec 26, 2014
gernotstarke added a commit that referenced this issue Dec 26, 2014
@gernotstarke
MissingLocalResourceChecker now has ref counter, closed #42
1883a41
gernotstarke added a commit that referenced this issue Dec 26, 2014
@gernotstarke
Merge branch 'feature/#42-local-resource-checker-ref-counter' into de…
a75ad54 
…velop
gernotstarke added a commit that referenced this issue Dec 26, 2014
@gernotstarke
updated changelog with #42, #65, #66, #68
128b020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gernotstarke gernotstarke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gernotstarke