Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace incorporated net.ricecode components #330

Open
ascheman opened this issue Aug 13, 2024 · 4 comments
Open

Replace incorporated net.ricecode components #330

ascheman opened this issue Aug 13, 2024 · 4 comments
Assignees
Labels
enhancement hacktoberfest This is a nice ticket for the hacktoberfest help-needed

Comments

@ascheman
Copy link
Member

ascheman commented Aug 13, 2024

As a developer of HSC I would like to get use the Java String Similarity library and drop the incorporated version of it from my source (as it meanwhile became publicly available on Maven Central).

@ascheman ascheman added the hacktoberfest This is a nice ticket for the hacktoberfest label Sep 7, 2024
@Prankurtiwari
Copy link

Prankurtiwari commented Oct 1, 2024

Hi @ascheman, I would like to discuss and work on this enhancement. Please let me know in case of any update

@ascheman
Copy link
Member Author

ascheman commented Oct 2, 2024

Thanks a lot, @Prankurtiwari, please add the library as new dependency and drop the overtaken classes. I hope it is not much more than this?

Are you on (the Hacktoberfest) Discord? You can reach out to me (gerdaschemann) so we could have a chat if you run into problems (or if you need any other support).

@Prankurtiwari
Copy link

Thanks for quick response @aschema. I will look into the project a

Thanks a lot, @Prankurtiwari, please add the library as new dependency and drop the overtaken classes. I hope it is not much more than this?

Are you on (the Hacktoberfest) Discord? You can reach out to me (gerdaschemann) so we could have a chat if you run into problems (or if you need any other support).

Thanks a lot, @Prankurtiwari, please add the library as new dependency and drop the overtaken classes. I hope it is not much more than this?

Are you on (the Hacktoberfest) Discord? You can reach out to me (gerdaschemann) so we could have a chat if you run into problems (or if you need any other support).

Thanks @ascheman for the quick response. I will try to resolve this issue and raise the PR.

Yes i am on the discord Hacktoberfest server. I have sent you the request and pinged you on discord. I will let you know if I need any assistance. Thanks :)

@Prankurtiwari
Copy link

Prankurtiwari commented Oct 11, 2024

Change PR : https://github.com/aim42/htmlSanityCheck/pull/351/files
Please review and merge

Prankurtiwari added a commit to Prankurtiwari/htmlSanityCheck that referenced this issue Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement hacktoberfest This is a nice ticket for the hacktoberfest help-needed
Projects
None yet
Development

No branches or pull requests

2 participants