Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for https://github.com/aim42/htmlSanityCheck/issues/282 #283

Merged
merged 3 commits into from
Apr 14, 2021

Conversation

oliva123456
Copy link
Contributor

hints:

unchanged:

  • doctoolchain/build.gradle: configuration names should get updated, too.

as commented in the issue, they have been failing testcases locally befor making the changes - and the tests still fail after my changes. at least running 'gradlew --warning-mode all' doesnt show any warnings / deprecations anymore.

Copy link
Collaborator

@rdmueller rdmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@oliva123456
Copy link
Contributor Author

as there were failing testcases on my machine (windows 10) i checked the tests: there were problems dealing with file separators.
i tested the fix on a windows10 machine and virtualbox/ubuntu and committed it.
probably i should have open a new issue/branch/pull request for it. sorry ;-(

@amottier
Copy link

@rdmueller I'm wondering what hold this PR from being merged? I'm in the process of upgrading a project to Gradle 7.0 and a new release of Html Sanity Check plugin that include this fix would be really appreciated 🙂

@gernotstarke
Copy link
Member

sorry - it's my fault... shame on me for not following up

@gernotstarke gernotstarke merged commit 16dc956 into aim42:master Apr 14, 2021
@gernotstarke
Copy link
Member

@amottier - for your info:

gernotstarke@iMac htmlSanityCheck % gradle publishPlugins

> Configure project :
after processResources config, version= 1.1.4

> Task :publishPlugins
Publishing plugin org.aim42.htmlSanityCheck version 1.1.4
Thank you. Your new plugin org.aim42.htmlSanityCheck has been submitted for approval by Gradle engineers. The request should be processed within the next few days, at which point you will be contacted via email.
Publishing artifact build/libs/htmlSanityCheck-1.1.4.jar
Publishing artifact build/libs/htmlSanityCheck-1.1.4.jar
Publishing artifact build/publications/pluginMaven/pom-default.xml
Publishing artifact build/publications/pluginMaven/module.json
Activating plugin org.aim42.htmlSanityCheck version 1.1.4

BUILD SUCCESSFUL in 10s
14 actionable tasks: 3 executed, 11 up-to-date
gernotstarke@iMac htmlSanityCheck %

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants