-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compatibility with gradle 7.0 / deprecation warnings within gradle 6.x #282
Comments
Thanx for the hint - I'd really appreciate to have the plugin continue with Gradle 7.x - but cannot invest any time in the near future due to other priorities (sorry for that). Would you be willing to provide or propose a fix via pull-request? @rdmueller - do you currently have any colleague within reach, who might support here? |
@gernotstarke - i will try to fix the issue and provide a request. a little problem is that i see failing tests when i run them after cloning the master locally (without any changes) => 305 tests completed, 6 failed. |
created the pull request: #283 |
question: are those input properties still optional? |
short answer: yes. the @optional annotation it is not just for "marking" parameters as optional, but rather more for making input validation optional. see: within my own gradle tasks all task parameters are optional (in the meaning of 'there is no need to declare the parameter when calling the task') without declaring them as @optional in the task (regardless of being a primitive or a real object). |
- Upgrade Gradle wrapper from version 3.3 to version 6.8.3. Not possible to upgrade to version 7.0 due to incompatible plugin (see aim42/htmlSanityCheck#282 should be fixed in htmlSanityCheck plugin version 1.1.4). - Keep only Xalan as build script dependency. - Include plugins using the `plugins` block instead of `apply` approach. - Added `baseDirFollowsSourceFile()` to asciidoctor configuration to fix issue relate to `include` directive with the new plugin version. - Update `asciidoctorj` to latest version. - Bump plugins to latest versions. - Removed unused repository. - Fix links in `reference.adoc` to "Customize the service section" (was missing path to the HTML file). - Fix link (invalid character) in `ProActiveAdminGuide.adoc`. - Fix links (avoid HTTP -> HTTPS redirection) and update URL for PyTorch torchvision documentation in `PMLUserGuide.adoc`. - Use `maven-publish` plugin instead of `maven` (can probably be removed). - IMPORTANT: replaced in `PMLUserGuide.adoc` https://s3.eu-west-2.amazonaws.com/activeeon-public/datasets/pascal_coco.zip by https://s3.eu-west-2.amazonaws.com/activeeon-public/datasets/ as `pascal_coco.zip` seems to be missing.
* Upgrade to Gradle 6.8.3 and various minor fixes - Upgrade Gradle wrapper from version 3.3 to version 6.8.3. Not possible to upgrade to version 7.0 due to incompatible plugin (see aim42/htmlSanityCheck#282 should be fixed in htmlSanityCheck plugin version 1.1.4). - Keep only Xalan as build script dependency. - Include plugins using the `plugins` block instead of `apply` approach. - Added `baseDirFollowsSourceFile()` to asciidoctor configuration to fix issue relate to `include` directive with the new plugin version. - Update `asciidoctorj` to latest version. - Bump plugins to latest versions. - Removed unused repository. - Fix links in `reference.adoc` to "Customize the service section" (was missing path to the HTML file). - Fix link (invalid character) in `ProActiveAdminGuide.adoc`. - Fix links (avoid HTTP -> HTTPS redirection) and update URL for PyTorch torchvision documentation in `PMLUserGuide.adoc`. - Use `maven-publish` plugin instead of `maven` (can probably be removed). - IMPORTANT: replaced in `PMLUserGuide.adoc` https://s3.eu-west-2.amazonaws.com/activeeon-public/datasets/pascal_coco.zip by https://s3.eu-west-2.amazonaws.com/activeeon-public/datasets/ as `pascal_coco.zip` seems to be missing. * Fix dataset link Fix the link to download COCO dataset. Co-authored-by: Antoine Mottier <antoine.mottier@bonitasoft.com>
running the gradle plugin using gradle 6.8.1 results in:
would be rather cool, if the plugin will still work with gradle 7 (after reading the warnings, i'm quite unsure if it will).
The text was updated successfully, but these errors were encountered: