Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compatibility with gradle 7.0 / deprecation warnings within gradle 6.x #282

Closed
oliva123456 opened this issue Jan 29, 2021 · 5 comments
Closed

Comments

@oliva123456
Copy link
Contributor

running the gradle plugin using gradle 6.8.1 results in:

Task :<....>:htmlSanityCheck
Property 'httpConnectionTimeout' @input properties with primitive type 'int' cannot be @optional. This behaviour has been deprecated and is scheduled to be removed in Gradle 7.0. See https://docs.gradle.org/6.6.1/userguide/more_about_tasks.html#sec:up_to_date_checks for more details.
Property 'ignoreIPAddresses' @input properties with primitive type 'boolean' cannot be @optional. This behaviour has been deprecated and is scheduled to be removed in Gradle 7.0. See https://docs.gradle.org/6.6.1/userguide/more_about_tasks.html#sec:up_to_date_checks for more details.
Property 'ignoreLocalHost' @input properties with primitive type 'boolean' cannot be @optional. This behaviour has been deprecated and is scheduled to be removed in Gradle 7.0. See https://docs.gradle.org/6.6.1/userguide/more_about_tasks.html#sec:up_to_date_checks for more details.

would be rather cool, if the plugin will still work with gradle 7 (after reading the warnings, i'm quite unsure if it will).

@gernotstarke
Copy link
Member

Thanx for the hint - I'd really appreciate to have the plugin continue with Gradle 7.x - but cannot invest any time in the near future due to other priorities (sorry for that).

Would you be willing to provide or propose a fix via pull-request?

@rdmueller - do you currently have any colleague within reach, who might support here?

@oliva123456
Copy link
Contributor Author

@gernotstarke - i will try to fix the issue and provide a request.

a little problem is that i see failing tests when i run them after cloning the master locally (without any changes) => 305 tests completed, 6 failed.

oliva123456 added a commit to oliva123456/htmlSanityCheck that referenced this issue Jan 29, 2021
@oliva123456
Copy link
Contributor Author

created the pull request: #283

@rdmueller
Copy link
Collaborator

question: are those input properties still optional?

@oliva123456
Copy link
Contributor Author

oliva123456 commented Jan 29, 2021

question: are those input properties still optional?

short answer: yes.

the @optional annotation it is not just for "marking" parameters as optional, but rather more for making input validation optional. see:
https://docs.gradle.org/6.8.1/userguide/more_about_tasks.html#sec:task_input_output_validation
https://docs.gradle.org/6.8.1/userguide/more_about_tasks.html#sec:up_to_date_checks
=> "You will occasionally want to disable some of this validation, specifically when an input file may validly not exist. That’s why Gradle provides the @optional annotation: you use it to tell Gradle that a particular input is optional and therefore the build should not fail if the corresponding file or directory doesn’t exist."

within my own gradle tasks all task parameters are optional (in the meaning of 'there is no need to declare the parameter when calling the task') without declaring them as @optional in the task (regardless of being a primitive or a real object).

gernotstarke added a commit that referenced this issue Apr 14, 2021
amottier added a commit to amottier/documentation that referenced this issue Apr 14, 2021
- Upgrade Gradle wrapper from version 3.3 to version 6.8.3. Not possible to upgrade to version 7.0 due to incompatible plugin (see aim42/htmlSanityCheck#282 should be fixed in htmlSanityCheck plugin version 1.1.4).
- Keep only Xalan as build script dependency.
- Include plugins using the `plugins` block instead of `apply` approach.
- Added `baseDirFollowsSourceFile()` to asciidoctor configuration to fix issue relate to `include` directive with the new plugin version.
- Update `asciidoctorj` to latest version.
- Bump plugins to latest versions.
- Removed unused repository.
- Fix links in `reference.adoc` to "Customize the service section" (was missing path to the HTML file).
- Fix link (invalid character) in `ProActiveAdminGuide.adoc`.
- Fix links (avoid HTTP -> HTTPS redirection) and update URL for PyTorch torchvision documentation in `PMLUserGuide.adoc`.
- Use `maven-publish` plugin instead of `maven` (can probably be removed).
- IMPORTANT: replaced in `PMLUserGuide.adoc` https://s3.eu-west-2.amazonaws.com/activeeon-public/datasets/pascal_coco.zip by https://s3.eu-west-2.amazonaws.com/activeeon-public/datasets/ as `pascal_coco.zip` seems to be missing.
fviale pushed a commit to ow2-proactive/documentation that referenced this issue Apr 23, 2021
* Upgrade to Gradle 6.8.3 and various minor fixes

- Upgrade Gradle wrapper from version 3.3 to version 6.8.3. Not possible to upgrade to version 7.0 due to incompatible plugin (see aim42/htmlSanityCheck#282 should be fixed in htmlSanityCheck plugin version 1.1.4).
- Keep only Xalan as build script dependency.
- Include plugins using the `plugins` block instead of `apply` approach.
- Added `baseDirFollowsSourceFile()` to asciidoctor configuration to fix issue relate to `include` directive with the new plugin version.
- Update `asciidoctorj` to latest version.
- Bump plugins to latest versions.
- Removed unused repository.
- Fix links in `reference.adoc` to "Customize the service section" (was missing path to the HTML file).
- Fix link (invalid character) in `ProActiveAdminGuide.adoc`.
- Fix links (avoid HTTP -> HTTPS redirection) and update URL for PyTorch torchvision documentation in `PMLUserGuide.adoc`.
- Use `maven-publish` plugin instead of `maven` (can probably be removed).
- IMPORTANT: replaced in `PMLUserGuide.adoc` https://s3.eu-west-2.amazonaws.com/activeeon-public/datasets/pascal_coco.zip by https://s3.eu-west-2.amazonaws.com/activeeon-public/datasets/ as `pascal_coco.zip` seems to be missing.

* Fix dataset link

Fix the link to download COCO dataset.

Co-authored-by: Antoine Mottier <antoine.mottier@bonitasoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants