Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rearrange README/vignette & check for duplicate file output #196

Merged
merged 3 commits into from
Feb 14, 2025

Conversation

RayStick
Copy link
Member

@RayStick RayStick commented Feb 14, 2025

Closes #195
References #184

In addition to closing #195, it also checks for the existence of the BAR_ plot and does not re-make if it finds it in the output_dir already (this is the same for every table run i.e. one BAR_ plot per dataset)

Checklist for the author of this PR:

  • [if package files were edited] I have run these checks locally:
    • devtools::document() to generates the .Rd files from any updated roxygen comments.
    • lintr::lint_package(path = ".") to check for style compliance and syntax issues.
    • codemetar::write_codemeta() to ensures the metadata file is up to date.
    • devtools::check() for a comprehensive package check. I have resolved any warnings or errors, or written them here in the PR, for discussion.
  • The code base and the documentation files match (they both reflect any recent changes).
  • The title of this PR is clear and self-explantory.
  • I have added any appropriate labels to this PR.
  • This PR is now ready for review (and I have removed the draft PR status).

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Feb 14, 2025
@RayStick RayStick changed the title Readme r1 4 Rearrange README and vignette, and check for duplicates file output Feb 14, 2025
@RayStick RayStick changed the title Rearrange README and vignette, and check for duplicates file output Rearrange README and vignett & check for duplicate file output Feb 14, 2025
@RayStick RayStick changed the title Rearrange README and vignett & check for duplicate file output Rearrange README/vignette & check for duplicate file output Feb 14, 2025
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 86.95652% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
R/metadata_map.R 86.95% 3 Missing ⚠️
Files with missing lines Coverage Δ
R/metadata_map.R 71.16% <86.95%> (-0.99%) ⬇️

@RayStick RayStick marked this pull request as ready for review February 14, 2025 09:07
@RayStick RayStick merged commit 18c486b into main Feb 14, 2025
8 of 9 checks passed
@RayStick RayStick deleted the README_R1-4 branch February 14, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rearrange README and vignette information (R1-4)
1 participant