PortNamespace: Make dynamic apply recursively

[sphuber]

The dynamic attribute of a port namespace indicates whether it should accept ports that are not explicitly defined. This was mostly used during validation, when a dictionary of port values was matched against a given PortNamespace.

This was, however, not being applied recursively and only during validation. For example, given a dynamic portnamespace, validating a dictionary:

{
    'nested': {
        'output': 'some_value'
    }
}

would pass validation without problems. However, the Process.out call that would actually attempt to attach the output to the process instance would call:

self.spec().outputs.get_port(namespace_separator.join(namespace))

which would raise, since get_port would raise a ValueError:

ValueError: port 'output' does not exist in port namespace 'nested'

The problem is that the nested namespace is expected, because the top level namespace was marked as dynamic, however, it itself would not also be treated as dynamic and so attempting to retrieve some_value from the nested namespace, would trigger a KeyError.

Here the logic in PortNamespace.get_port is updated to check in advance whether the port exists in the namespace, and if not the case and the namespace is dynamic, the nested port namespace is created. The attributes of the new namespace are inherited from its parent namespace, making the dynamic attribute act recursively.

[sphuber]

@unkcpz This change is required for aiidateam/aiida-core#5954 So in order to provide the proper context, it may make sense to read through that aiida-core PR as well. It is only a few lines, so should be quick.

[codecov]

Codecov Report

Patch and project coverage have no change.

Comparison is base (6f5d326) 90.82% compared to head (6f5d326) 90.82%.

❗ Current head 6f5d326 differs from pull request most recent head 5d50128. Consider uploading reports for the commit 5d50128 to get more accurate results

Additional details and impacted files

@@               Coverage Diff               @@
##           support/0.21.x     #263   +/-   ##
===============================================
  Coverage           90.82%   90.82%           
===============================================
  Files                  21       21           
  Lines                2971     2971           
===============================================
  Hits                 2698     2698           
  Misses                273      273           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[unkcpz]

Looks good to me!