Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GHA config #35

Merged
merged 8 commits into from
Jul 12, 2023
Merged

Fix GHA config #35

merged 8 commits into from
Jul 12, 2023

Conversation

danielhollas
Copy link
Contributor

Attempting to fix GHA configuration.

@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2023

Codecov Report

Patch coverage has no change and project coverage change: +2.25 🎉

Comparison is base (7b3319f) 93.78% compared to head (268d1e9) 96.04%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
+ Coverage   93.78%   96.04%   +2.25%     
==========================================
  Files           2        2              
  Lines         177      177              
==========================================
+ Hits          166      170       +4     
+ Misses         11        7       -4     
Impacted Files Coverage Δ
pgsu/cli.py 100.00% <ø> (+8.33%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@danielhollas
Copy link
Contributor Author

@ltalirz the tests are failing on the ubuntu-22.04 image with Postgresql-14. I am not sure why, it looks like psycopg can't find the proper socket for connection, see https://github.com/aiidateam/pgsu/actions/runs/5523688427/jobs/10074949017

Otherwise this is good to go.

Copy link
Member

@ltalirz ltalirz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot @danielhollas for this help, much appreciated!

I have one small request, if that's ok

@@ -21,6 +21,8 @@ classifiers =
Programming Language :: Python :: 3.7
Copy link
Member

@ltalirz ltalirz Jul 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder whether this will remain true... ;-)
anyhow, fine to keep for the time being

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're still testing 3.7 so this should be fine, but I've dropped the 3.6 version since that one has been EOLed for a while anyway. (I believe 3.7 was still receiving security releases up until couple months go...)

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@danielhollas danielhollas requested a review from ltalirz July 11, 2023 23:16
Copy link
Member

@ltalirz ltalirz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot @danielhollas !

@ltalirz ltalirz merged commit 5d7d158 into aiidateam:master Jul 12, 2023
@danielhollas danielhollas deleted the fix-gha branch July 12, 2023 15:49
@danielhollas
Copy link
Contributor Author

danielhollas commented Jul 12, 2023

Hmm, Codecov upload still fails, strange. Maybe some repo settings or settings on Codecov needs to be tweaked?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants