-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GHA config #35
Fix GHA config #35
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #35 +/- ##
==========================================
+ Coverage 93.78% 96.04% +2.25%
==========================================
Files 2 2
Lines 177 177
==========================================
+ Hits 166 170 +4
+ Misses 11 7 -4
☔ View full report in Codecov by Sentry. |
@ltalirz the tests are failing on the ubuntu-22.04 image with Postgresql-14. I am not sure why, it looks like psycopg can't find the proper socket for connection, see https://github.com/aiidateam/pgsu/actions/runs/5523688427/jobs/10074949017 Otherwise this is good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks a lot @danielhollas for this help, much appreciated!
I have one small request, if that's ok
@@ -21,6 +21,8 @@ classifiers = | |||
Programming Language :: Python :: 3.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder whether this will remain true... ;-)
anyhow, fine to keep for the time being
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're still testing 3.7
so this should be fine, but I've dropped the 3.6
version since that one has been EOLed for a while anyway. (I believe 3.7 was still receiving security releases up until couple months go...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks a lot @danielhollas !
Hmm, Codecov upload still fails, strange. Maybe some repo settings or settings on Codecov needs to be tweaked? |
Attempting to fix GHA configuration.