Updated yaml code to support 5.1 #35
Conversation
| 'Programming Language :: Python :: 3.7', | ||
| ], | ||
| keywords='communication messaging rpc broadcast', | ||
| install_requires=[ |
There was a problem hiding this comment.
While we're at it, do you want to specify python_requires here? This allows pip to install the correct version once support for a specific Python version is dropped (but needs to be in a release before it is dropped).
See e.g.: aiidateam/aiida-core#3574
kiwipy/rmq/defaults.py
Outdated
| @@ -18,4 +18,4 @@ | |||
| TASK_PREFETCH_COUNT = 0 | |||
|
|
|||
| ENCODER = partial(yaml.dump, encoding='utf-8') | |||
| DECODER = yaml.load | |||
| DECODER = lambda _: yaml.load(_, Loader=yaml.Loader) | |||
There was a problem hiding this comment.
Since the value of _ is actually used, maybe it should be named? Keeping with the naming from pyyaml, it would be lambda stream: yaml.load(stream, Loader=yaml.Loader).
There was a problem hiding this comment.
Or better yet, same as above: partial(yaml.load, Loader=yaml.Loader). Totally bike-shedding here though, feel free to merge whenever.
There was a problem hiding this comment.
Haha, yes, talk about not looking at the line above!
kiwipy/rmq/defaults.py
Outdated
| @@ -18,4 +18,4 @@ | |||
| TASK_PREFETCH_COUNT = 0 | |||
|
|
|||
| ENCODER = partial(yaml.dump, encoding='utf-8') | |||
| DECODER = yaml.load | |||
| DECODER = lambda _: yaml.load(_, Loader=yaml.Loader) | |||
There was a problem hiding this comment.
Or better yet, same as above: partial(yaml.load, Loader=yaml.Loader). Totally bike-shedding here though, feel free to merge whenever.
muhrin
force-pushed
the
yaml-update
branch
2 times, most recently
from
21e7344 to
e711a2f
Compare
Had to pin prospector at <1.1.7 which has problems with pylint, see: pylint-dev/pylint-plugin-utils#12 Also took opportunity to up pika to 1.0 and above.
Had to pin prospector at <1.1.7 which has problems with pylint, see:
pylint-dev/pylint-plugin-utils#12
Also took opportunity to up pika to 1.0 and above.