[BLOCKED] Server properties #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This exposes the server properties as returned by the RMQ server when connecting to clients of the async and threaded RMQ communicators. This is useful for, amongst other things, checking the server vertsion to ensure compatibility.
Closed
4 tasks
|
Looks good, I'll wait for you to work out why all the tests are failing 😅 |
| @@ -345,6 +345,13 @@ async def __aexit__(self, exc_type, exc_val, exc_tb): | |||
| def __str__(self): | |||
| return f'RMQCommunicator({self._connection})' | |||
|
|
|||
| @property | |||
| def server_properties(self) -> Dict: | |||
|
Thanks, I'll try and figure out what's going on test side... |
sphuber
reviewed
Jan 12, 2022
* Added server_properties test to threaded RMQ communicator
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #107 +/- ##
===========================================
- Coverage 90.34% 90.32% -0.01%
===========================================
Files 16 16
Lines 1138 1146 +8
===========================================
+ Hits 1028 1035 +7
- Misses 110 111 +1 ☔ View full report in Codecov by Sentry. |
sphuber
approved these changes
Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes information about the RMQ server to communicator clients. Could be useful for AiiDA as this allows the version number to be determined.